Projet

Général

Profil

Révision 30462da1

ID30462da12b2eca072bdd9c13b1970958ff962745
Parent 92461926
Enfant bd549474

Ajouté par Steve Traylen il y a plus de 4 ans

Reload rules atomically

Background: The unit file for nftables on CentOS 8 contains:

```
ExecStart=/sbin/nft -f /etc/sysconfig/nftables.conf
ExecReload=/sbin/nft 'flush ruleset; include "/etc/sysconfig/nftables.conf";'
ExecStop=/sbin/nft flush ruleset
```

As things stood on config modication `systemctl stop nftables ; systemctl start nftables` was being
called resulting in:

```
nft flush ruleset
nft -f /etc/sysconfig/nftables.conf
```

as distinct commands so a non-atomic flush and load of ruleset.

With this change it is now.

```
/sbin/nft 'flush ruleset; include "/etc/sysconfig/nftables.conf";'
```

There is subsequently a redundant extra 'flush ruleset' in there to be followed
up in a seperate patch as I have desire to make that tunable.

To verify what happens when broken rules have been applied, e.g

```puppet
nftables::rule{'default_in-junk':
content => 'junk',
}
```

This results in puppet run of

```
Error: /Stage[main]/Nftables/Service[nftables]: Failed to call refresh: Systemd restart for nftables failed!
journalctl log for nftables:
```

and the existing rules are left live, previously the flush from the stop was occuring.

The reload attempt would only happen once however leaving a time bomb at reboot.
To resvole this the configuration is modified to force a reconfig and reload every puppet run.

Voir les différences:

manifests/config.pp
9 9

  
10 10
  Package['nftables'] -> concat{
11 11
    $concat_name:
12
      path           => "/etc/nftables/puppet/${name}.nft",
12
      path           => "/etc/nftables/puppet-preflight/${name}.nft",
13 13
      ensure_newline => true,
14 14
      owner          => root,
15 15
      group          => root,
16 16
      mode           => '0640',
17
  } ~> Exec['nft validate'] -> file{
18
    "/etc/nftables/puppet/${name}.nft":
19
    ensure => file,
20
    source => "/etc/nftables/puppet-preflight/${name}.nft",
21
    owner  => root,
22
    group  => root,
23
    mode   => '0640',
17 24
  } ~> Service['nftables']
18 25

  
19 26
  $data = split($name, '-')

Formats disponibles : Unified diff