Projet

Général

Profil

Révision c81c20ab

IDc81c20ab3b60512ac86beaa0a0ea4dfafa76e1dd
Parent 270be2f5
Enfant cc0b0949

Ajouté par Lars Kruse il y a plus de 7 ans

unify DIRTYCONFIG handling in shell and python plugins

The following issues were fixed:
  • comparison too broad (e.g. "0" misinterpreted as "true")
  • python: comparing string with number (is never equal in python)
  • unwanted non-zero exitcode (compound command "&&" as last command in
    shell code block (e.g. "case" or "if" branch))
  • access to unset variable (shell style issue)

Voir les différences:

plugins/wifi/wireless_signal_noise_
147 147
case "$ACTION" in
148 148
	config)
149 149
		do_config || exit 1
150
		[ "${MUNIN_CAP_DIRTYCONFIG:-0}" = 1 ] && do_fetch
150
		if [ "${MUNIN_CAP_DIRTYCONFIG:-0}" = "1" ]; then do_fetch; fi
151 151
		;;
152 152
	autoconf)
153 153
		if [ -z "$(get_wifi_interfaces)" ]; then

Formats disponibles : Unified diff